Skip to content

fix for pinned versioning behavior on server version >=1.28.0 #1754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 31, 2025
Merged

fix for pinned versioning behavior on server version >=1.28.0 #1754

merged 3 commits into from
Jul 31, 2025

Conversation

@jbrody-nexxa
Copy link
Contributor

@jbrody-nexxa jbrody-nexxa commented Jul 31, 2025 •
edited
Loading

What was changed

Added missing v0.32 attribute to pinned override in workflow-options.ts

Why?

Bugfix for #1753

Checklist

  1. Closes [Bug] Calling a Workflow with Worker Versioning and PINNED behavior in versionOverrides fails in Temporal Server >=1.28.0 #1753

  2. How was this tested:
    Covered by existing integration test: test-worker-deployment-versioning.ts

  • Before my change, on server version 1.27.1, this integration test passes
  • Before my change, on server version 1.28.0, this integration test fails:
@temporalio/test:   worker-deployment-versioning › Workflow versioningOverride overrides default versioning behavior
@temporalio/test:   Rejected promise returned by test. Reason:
@temporalio/test:   ServiceError {
@temporalio/test:     cause: Error {
@temporalio/test:       code: 3,
@temporalio/test:       details: 'must specify pinned override behavior if override is pinned.',
@temporalio/test:       metadata: Metadata {
@temporalio/test:         internalRepr: Map { … },
@temporalio/test:         options: {},
@temporalio/test:       },
@temporalio/test:       message: '3 INVALID_ARGUMENT: must specify pinned override behavior if override is pinned.',
@temporalio/test:     },
@temporalio/test:     message: 'Failed to start Workflow',
@temporalio/test:   }
@temporalio/test:   › TimeSkippingWorkflowClient.rethrowGrpcError (/Users/johnbrody/github/sdk-typescript/packages/client/src/workflow-client.ts:911:13)
@temporalio/test:   › TimeSkippingWorkflowClient._startWorkflowHandler (/Users/johnbrody/github/sdk-typescript/packages/client/src/workflow-client.ts:1264:12)
@temporalio/test:   › async TimeSkippingWorkflowClient.start (/Users/johnbrody/github/sdk-typescript/packages/client/src/workflow-client.ts:566:19)
@temporalio/test:   › async <anonymous> (src/test-worker-deployment-versioning.ts:393:20)
  • After my change, on both server version 1.27.1 and 1.28.0, this integration test passes
  1. Any docs updates needed?
    No

@jbrody-nexxa jbrody-nexxa requested a review from a team as a code owner July 31, 2025 01:12
@jbrody-nexxa jbrody-nexxa mentioned this pull request Jul 31, 2025
Closed
mjameswh
mjameswh approved these changes Jul 31, 2025
View reviewed changes
Copy link
Contributor

@mjameswh mjameswh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jbrody-nexxa, that indeed seems right.

@mjameswh mjameswh merged commit 260b570 into temporalio:main Jul 31, 2025
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjameswh mjameswh mjameswh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Calling a Workflow with Worker Versioning and PINNED behavior in versionOverrides fails in Temporal Server >=1.28.0

2 participants

@jbrody-nexxa @mjameswh